Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replies to outdated code comments should also be outdated (#13217) #13433

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Replies to outdated code comments should also be outdated (#13217) #13433

merged 1 commit into from
Nov 5, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 5, 2020

Partial Backport of #13217

@zeripath @techknowlogick @6543
Replies to outdated code comments should also be outdated (go-gitea#1…
3e2a2a9 
…3217)

* When replying to an outdated comment it should not appear on the files page

This happened because the comment took the latest commitID as its base instead of the
reviewID that it was replying to.

There was also no way of creating an already outdated comment - and a
reply to a review on an outdated line should be outdated.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* fix test

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@6543 6543 mentioned this pull request Nov 5, 2020
Merged
@6543 6543 added the type/bug label Nov 5, 2020
@6543 6543 added this to the 1.13.0 milestone Nov 5, 2020
@zeripath
Copy link
Contributor

zeripath commented Nov 5, 2020

This could potentially do with the migration being backported as a doctor check?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 5, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 5, 2020
@6543
Copy link
Member Author

6543 commented Nov 5, 2020

🚀

@zeripath I'll create new pull for doctor - I think this doctor task will need more 👀 ...

@6543
Copy link
Member Author

6543 commented Nov 5, 2020

-> #13436

@techknowlogick techknowlogick merged commit 9aa580c into go-gitea:release/v1.13 Nov 5, 2020
@6543 6543 deleted the backport_replies_outdated_code-comments_13217 branch November 5, 2020 20:24
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @zeripath @lafriks @techknowlogick @GiteaBot