Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Nov 3, 2020

If the releases already have publisher id, the migration in v156 will override them. It's horrible.

This PR will fix that.

@lunny lunny added the type/bug label Nov 3, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 3, 2020
@zeripath zeripath added this to the 1.14.0 milestone Nov 3, 2020
@zeripath
Copy link
Contributor

zeripath commented Nov 3, 2020

Sorry I missed that it was not intentional - I had thought that was intentional.

Copy link
Member

@a1012112796 a1012112796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 3, 2020
@lunny
Copy link
Member Author

lunny commented Nov 3, 2020

make L-G-T-M work.

@lunny lunny merged commit afb3a5c into go-gitea:master Nov 3, 2020
@lunny lunny deleted the lunny/fix_release_migrate branch November 3, 2020 15:47
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants