Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Move PushUpdateOptions #13363

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 30, 2020

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Oct 30, 2020
@codecov-io
Copy link

Codecov Report

Merging #13363 into master will increase coverage by 0.00%.
The diff coverage is 59.77%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13363   +/-   ##
=======================================
  Coverage   42.12%   42.12%           
=======================================
  Files         689      690    +1     
  Lines       75851    75865   +14     
=======================================
+ Hits        31949    31960   +11     
- Misses      38670    38674    +4     
+ Partials     5232     5231    -1     
Impacted Files Coverage Δ
modules/notification/action/action.go 58.26% <0.00%> (ø)
services/mirror/mirror.go 15.98% <0.00%> (-0.19%) ⬇️
modules/notification/base/null.go 74.28% <50.00%> (ø)
modules/notification/indexer/indexer.go 48.61% <50.00%> (ø)
modules/notification/notification.go 83.92% <50.00%> (ø)
modules/notification/webhook/webhook.go 49.30% <50.00%> (ø)
modules/repository/push.go 54.76% <54.76%> (ø)
routers/api/v1/repo/branch.go 36.85% <100.00%> (ø)
routers/private/hook.go 32.29% <100.00%> (ø)
routers/repo/branch.go 56.35% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b33afc...dbafbec. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 30, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 30, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 30, 2020
@sapk
Copy link
Member

sapk commented Oct 30, 2020

make lgtm work

@sapk sapk merged commit 4df2ed2 into go-gitea:master Oct 30, 2020
@lunny lunny deleted the lunny/move_push_update_options branch October 31, 2020 00:36
@lunny lunny mentioned this pull request Oct 31, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants