Skip to content

Migration failure during reaction migration from gitea (#13344) #13345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2020
Merged

Migration failure during reaction migration from gitea (#13344) #13345

merged 2 commits into from
Oct 29, 2020

Conversation

@techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Oct 29, 2020

  • Migrating reactions is just not that important

A failure during migrating reactions should not cause failure of
migration.

Signed-off-by: Andrew Thornton art27@cantab.net

  • When checking issue reactions check the correct permission

Credit @zeripath

@zeripath @techknowlogick
Migration failure during reaction migration from gitea (go-gitea#13344)
6a5e1ad 
* Migrating reactions is just not that important

A failure during migrating reactions should not cause failure of
migration.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* When checking issue reactions check the correct permission

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@techknowlogick techknowlogick added this to the 1.13.0 milestone Oct 29, 2020
@techknowlogick techknowlogick added type/bug topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them labels Oct 29, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 29, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 29, 2020
@techknowlogick
Copy link
Member Author

techknowlogick commented Oct 29, 2020

🚀

@techknowlogick techknowlogick merged commit 0b04563 into go-gitea:release/v1.13 Oct 29, 2020
@techknowlogick techknowlogick deleted the backport-13344 branch October 29, 2020 03:57
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 10, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@jolheiser jolheiser jolheiser approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them type/bug

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

6 participants

@techknowlogick @lunny @zeripath @jolheiser @GiteaBot @6543