Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notice for webhook payload's secret field #13329

Conversation

JustAnotherArchivist
Copy link
Contributor

Part of #11755

This PR is against release/v1.13 because the deprecation notice belong in those docs. There should be no need to include it in the master (1.14) docs as the field will no longer exist in the releases based on that branch. A separate PR for that removal will follow.

@jolheiser
Copy link
Member

Our docs only show the latest version, so I'm afraid this likely won't be seen by anyone. 🙁

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 27, 2020
@JustAnotherArchivist
Copy link
Contributor Author

Oh, that's unfortunate. I'll submit a PR against the master branch then. It might still be good to have this in the docs for v1.13.0, even if those aren't shown on docs.gitea.io, but I'll leave that decision up to you of course.

@techknowlogick
Copy link
Member

Using 🧙 to merge this, as we do distribute a .zip of the docs for each release now, so it doesn't hurt to merge this in case someone is reading docs offline.

@techknowlogick techknowlogick merged commit 639c737 into go-gitea:release/v1.13 Oct 29, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants