-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage configuration support [storage]
#13314
Conversation
f86ca3a
to
8c5bec1
Compare
|
The file tested in LFS is 10 bytes, and the request is range=11-, so the correct response of HTTP standard is to return an error or just ignore that? The behaviour between |
It should be fixed for file and minio to behave the same and handle that |
@lafriks Yes, so which one should choose? Return io.EOF or just ignore them? |
95bdb4f
to
d060e31
Compare
OK. I think https://developer.mozilla.org/en-US/docs/Web/HTTP/Range_requests explained we should return 416.
|
a930f33
to
886fbfb
Compare
🚀 |
@lunny please send backport :) |
* Fix minio bug * Add tests for storage configuration * Change the Seek flag to keep compitable minio? * Fix test when first-byte-pos of all ranges is greater than the resource length Co-authored-by: techknowlogick <techknowlogick@gitea.io>
* Fix minio bug * Add tests for storage configuration * Change the Seek flag to keep compitable minio? * Fix test when first-byte-pos of all ranges is greater than the resource length Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
This PR adjusted the override sequence,
[storage]
<-[storage.minio]
<-[storage.attachments]
. Right section will override left.In fact,
[storage]
is expected because it's more easier to remember.This will also enable storage tests with minio when mysql integration tests.
This also changed the behaviour of lfs serve when given a range start value out of bounds, now it will return 416, but not ignore that like before.