Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HostCertificate lines to sshd_config #13143

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Conversation

aes
Copy link
Contributor

@aes aes commented Oct 14, 2020

Afaik, adding these lines does nothing unless the file(s) are present. Having them in let's admins supply certs instead of relying on TOFU.

Afaik, adding these lines does nothing unless the file(s) are present. Having them in let's admins supply certs instead of relying on TOFU.
@codecov-io
Copy link

Codecov Report

Merging #13143 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13143      +/-   ##
==========================================
- Coverage   42.13%   42.11%   -0.02%     
==========================================
  Files         678      678              
  Lines       75041    75041              
==========================================
- Hits        31617    31603      -14     
- Misses      38275    38292      +17     
+ Partials     5149     5146       -3     
Impacted Files Coverage Δ
models/repo_mirror.go 2.38% <0.00%> (-11.91%) ⬇️
modules/cron/tasks_basic.go 87.35% <0.00%> (-3.45%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/log/event.go 59.90% <0.00%> (-1.89%) ⬇️
modules/git/blame.go 75.43% <0.00%> (-1.76%) ⬇️
services/mirror/mirror.go 18.51% <0.00%> (-1.35%) ⬇️
routers/repo/view.go 37.47% <0.00%> (-0.65%) ⬇️
models/issue_comment.go 52.93% <0.00%> (-0.16%) ⬇️
models/error.go 34.39% <0.00%> (ø)
modules/util/timer.go 85.71% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93f7525...7495042. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 14, 2020
@zeripath zeripath added the type/enhancement An improvement of existing functionality label Oct 14, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 14, 2020
@zeripath zeripath added this to the 1.14 milestone Oct 14, 2020
@zeripath
Copy link
Contributor

This could go into 1.13 if it is approved quickly enough.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 14, 2020
@techknowlogick techknowlogick modified the milestones: 1.14, 1.13.0 Oct 14, 2020
@techknowlogick techknowlogick merged commit 01f991a into go-gitea:master Oct 14, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants