Skip to content

Conversation

@6543
Copy link
Member

@6543 6543 commented Oct 12, 2020

as title

if there was only a created but not a updated added, the only update this table get is a delete then

xorm create and update this timestamps - so we do not have to do add extra code to handle

this pull is mainly to have data saved, adding features & functions based on this is NOT part of THIS pull

@6543 6543 added the type/enhancement An improvement of existing functionality label Oct 12, 2020
@6543 6543 changed the title Add timestamps to Star, Label, Follow, Watch and Collaboration Save TimeStamps for Star, Label, Follow, Watch and Collaboration to Database Oct 12, 2020
@6543 6543 added this to the 1.13.0 milestone Oct 12, 2020
@6543
Copy link
Member Author

6543 commented Oct 12, 2020

here it is :)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 12, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 12, 2020
@zeripath
Copy link
Contributor

zeripath commented Oct 12, 2020

Need to fix issue_label_test.go:266 it does a equals which won't work now because the timestamp is updated

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 13, 2020
@techknowlogick techknowlogick merged commit f4ffe8e into go-gitea:master Oct 13, 2020
@6543 6543 deleted the add_create-columns branch October 13, 2020 00:02
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants