Skip to content

Conversation

@6543
Copy link
Member

@6543 6543 commented Oct 12, 2020

as title + one nit missed in #13108

@6543 6543 added modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality labels Oct 12, 2020
@6543 6543 added this to the 1.13.0 milestone Oct 12, 2020
@6543 6543 requested a review from zeripath October 12, 2020 15:26
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 12, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 13, 2020
@codecov-io
Copy link

Codecov Report

Merging #13115 into master will increase coverage by 0.12%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13115      +/-   ##
==========================================
+ Coverage   42.25%   42.37%   +0.12%     
==========================================
  Files         675      675              
  Lines       74520    74520              
==========================================
+ Hits        31485    31576      +91     
+ Misses      37922    37812     -110     
- Partials     5113     5132      +19     
Impacted Files Coverage Δ
models/migrations/migrations.go 2.44% <0.00%> (ø)
modules/context/api.go 75.22% <50.00%> (ø)
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
services/pull/check.go 47.69% <0.00%> (-2.31%) ⬇️
models/error.go 34.39% <0.00%> (ø)
services/pull/pull.go 40.78% <0.00%> (+0.49%) ⬆️
modules/log/event.go 60.84% <0.00%> (+0.94%) ⬆️
services/mailer/mail.go 55.91% <0.00%> (+1.07%) ⬆️
services/gitdiff/gitdiff.go 74.48% <0.00%> (+1.63%) ⬆️
modules/charset/charset.go 70.78% <0.00%> (+2.24%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ffe8e...abf22bf. Read the comment docs.

@6543
Copy link
Member Author

6543 commented Oct 13, 2020

🚀

@techknowlogick techknowlogick merged commit ade9c8d into go-gitea:master Oct 13, 2020
@6543 6543 deleted the api_500-err_show-message-to-admin branch October 13, 2020 00:41
@lunny
Copy link
Member

lunny commented Oct 13, 2020

That means Gitea admin should be also system admin.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants