Skip to content

Conversation

@divbhasin
Copy link
Contributor

Context

Gitea makes authorized_keys backups by default. People following along with the "Installing with Docker" > "SSH Container Passthrough" section are asked to symlink their authorized_keys folder with a volume that is mounted inside the container, as described here: https://docs.gitea.io/en-us/install-with-docker/#ssh-container-passthrough. However, this symlink can end up pointing to a backup, leading to ssh not working as described in #12625.

Solution

Add the recommendation given by the author of #12625 as a second option to the docs and tell users to turn off authorized_keys backup if they want to go with the first option.

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2020

Codecov Report

Merging #13030 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13030      +/-   ##
==========================================
- Coverage   42.55%   42.54%   -0.01%     
==========================================
  Files         672      672              
  Lines       73715    73715              
==========================================
- Hits        31370    31364       -6     
  Misses      37269    37269              
- Partials     5076     5082       +6     
Impacted Files Coverage Δ
modules/notification/ui/ui.go 80.55% <0.00%> (-2.78%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
services/pull/check.go 47.69% <0.00%> (-2.31%) ⬇️
models/notification.go 65.76% <0.00%> (-0.91%) ⬇️
models/error.go 34.34% <0.00%> (-0.85%) ⬇️
routers/repo/view.go 37.47% <0.00%> (-0.65%) ⬇️
modules/notification/mail/mail.go 34.48% <0.00%> (ø)
services/mailer/mail.go 55.91% <0.00%> (+1.07%) ⬆️
modules/log/event.go 59.43% <0.00%> (+1.88%) ⬆️
modules/indexer/stats/db.go 52.17% <0.00%> (+8.69%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01c7204...98e36aa. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 4, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 4, 2020
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Oct 4, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 4, 2020
@techknowlogick techknowlogick merged commit 48703c3 into go-gitea:master Oct 4, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants