Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the color of PR comment hyperlinks. #13009

Merged

Conversation

rebeckanylander
Copy link
Contributor

Fix issue #12995 by limiting the grey-color span up to cover the comment header only.

@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Oct 1, 2020
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2020

Codecov Report

Merging #13009 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13009      +/-   ##
==========================================
- Coverage   42.61%   42.48%   -0.14%     
==========================================
  Files         671      671              
  Lines       73635    73635              
==========================================
- Hits        31382    31282     -100     
- Misses      37171    37290     +119     
+ Partials     5082     5063      -19     
Impacted Files Coverage Δ
models/issue_comment.go 44.41% <0.00%> (-9.50%) ⬇️
modules/notification/ui/ui.go 72.22% <0.00%> (-8.34%) ⬇️
modules/notification/mail/mail.go 28.73% <0.00%> (-5.75%) ⬇️
modules/git/commit.go 50.67% <0.00%> (-4.06%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/notification/base/null.go 68.57% <0.00%> (-2.86%) ⬇️
modules/notification/notification.go 78.57% <0.00%> (-2.68%) ⬇️
services/pull/check.go 47.69% <0.00%> (-2.31%) ⬇️
services/mailer/mail.go 54.83% <0.00%> (-1.08%) ⬇️
models/error.go 34.34% <0.00%> (-0.51%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a34fc0...eac29d1. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 1, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 2, 2020
@mrsdizzie
Copy link
Member

Thanks!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 2, 2020
Copy link
Contributor

@bagasme bagasme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to differentiate link color between unvisited and visited link, something like:

a:visited {
    color: something;
}

a:link {
    color: other;
}

Otherwise, ack.

@mrsdizzie
Copy link
Member

You may want to differentiate link color between unvisited and visited link, something like:

a:visited {
    color: something;
}

a:link {
    color: other;
}

Otherwise, ack.

That shouldn't change (and example above would be a site wide change) and PR is good as is.

@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 54091e0 into go-gitea:master Oct 2, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Oct 2, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants