Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Re)Load issue labels when changing them #13007

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Oct 1, 2020

(Re)Load issue labels when labels are added or removed

This means that the label state that the webhooks produce accurately matches
the changes that they are reporting.

Fix #10660

Signed-off-by: Andrew Thornton art27@cantab.net

(Re)Load issue labels when labels are added or removed

This means that the label state that the webhooks produce accurately matches
the changes that they are reporting.

Fix go-gitea#10660

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.13.0 milestone Oct 1, 2020
@zeripath
Copy link
Contributor Author

zeripath commented Oct 1, 2020

(I have confirmed that this works for the testcase on the associated PR)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 1, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #13007 into master will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13007   +/-   ##
=======================================
  Coverage   42.58%   42.58%           
=======================================
  Files         671      671           
  Lines       73632    73644   +12     
=======================================
+ Hits        31358    31364    +6     
- Misses      37188    37191    +3     
- Partials     5086     5089    +3     
Impacted Files Coverage Δ
models/issue.go 56.58% <33.33%> (-0.07%) ⬇️
models/issue_label.go 67.15% <33.33%> (-0.76%) ⬇️
modules/log/event.go 57.54% <0.00%> (-1.89%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
models/gpg_key.go 53.33% <0.00%> (-0.58%) ⬇️
models/error.go 34.85% <0.00%> (+0.50%) ⬆️
modules/git/repo.go 46.70% <0.00%> (+0.50%) ⬆️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️
modules/git/utils.go 77.04% <0.00%> (+3.27%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f3dbe...fc0c5e6. Read the comment docs.

models/issue.go Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 5, 2020
@lafriks lafriks merged commit 5e1c51c into go-gitea:master Oct 5, 2020
@zeripath zeripath deleted the fix-10660-Ensure-labels-are-loaded-before-webhook branch October 5, 2020 08:24
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhook sends wrong PR state
6 participants