-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Return sample message for login error in api context #12994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: a1012112796 <1012112796@qq.com>
Co-authored-by: silverwind <me@silverwind.io>
Codecov Report
@@ Coverage Diff @@
## master #12994 +/- ##
==========================================
+ Coverage 42.51% 42.54% +0.03%
==========================================
Files 672 672
Lines 73699 73715 +16
==========================================
+ Hits 31336 31365 +29
+ Misses 37284 37265 -19
- Partials 5079 5085 +6
Continue to review full report at Codecov.
|
Co-authored-by: Lauris BH <lauris@nix.lv>
zeripath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these suggestions read a bit better but otherwise LGTM.
Co-authored-by: zeripath <art27@cantab.net>
As title, will return a sample message instead of full html page.