Skip to content

Refactor use TrimSuffix instead of TrimRight #12993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 1, 2020
Merged

Refactor use TrimSuffix instead of TrimRight #12993

merged 3 commits into from
Oct 1, 2020

Conversation

@6543
Copy link
Member

@6543 6543 commented Oct 1, 2020

as title

@6543 6543 added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Oct 1, 2020
6543
6543 commented Oct 1, 2020
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 1, 2020
@6543 6543 requested a review from techknowlogick October 1, 2020 03:09
techknowlogick
techknowlogick reviewed Oct 1, 2020
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2020 •
edited
Loading

Codecov Report

Merging #12993 into master will increase coverage by 0.02%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12993      +/-   ##
==========================================
+ Coverage   42.58%   42.60%   +0.02%     
==========================================
  Files         671      671              
  Lines       73625    73625              
==========================================
+ Hits        31350    31369      +19     
+ Misses      37188    37172      -16     
+ Partials     5087     5084       -3
Impacted Files Coverage Δ
cmd/web.go 0.00% <0.00%> (ø)
models/user.go 53.58% <100.00%> (ø)
modules/setting/setting.go 47.61% <100.00%> (ø)
services/pull/pull.go 40.78% <0.00%> (ø)
models/error.go 34.85% <0.00%> (+0.50%) ⬆️
services/gitdiff/gitdiff.go 74.48% <0.00%> (+1.63%) ⬆️
modules/charset/charset.go 70.78% <0.00%> (+2.24%) ⬆️
services/pull/check.go 50.00% <0.00%> (+2.30%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 551473b...775cd66. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 1, 2020
6543
6543 commented Oct 1, 2020
View reviewed changes
@6543
Copy link
Member Author

6543 commented Oct 1, 2020

@techknowlogick done

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 1, 2020
@zeripath zeripath merged commit 818d921 into go-gitea:master Oct 1, 2020
@6543 6543 deleted the refactor_TrimRight-2-TrimSuffix branch October 1, 2020 06:07
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@6543 @codecov-commenter @lunny @techknowlogick @zeripath @GiteaBot