Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting of branches ahead-behind on narrow windows #12989

Merged
merged 3 commits into from
Oct 2, 2020
Merged

Fix formatting of branches ahead-behind on narrow windows #12989

merged 3 commits into from
Oct 2, 2020

Conversation

zeripath
Copy link
Contributor

Make the bar-groups width 50% with max-width of 90px

Fix #12252

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Fix formatting of branches ahead-behind on narrow windows
9797305 
Make the bar-groups width 50% with max-width of 90px

Fix go-gitea#12252

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Sep 30, 2020
@zeripath zeripath added this to the 1.13.0 milestone Sep 30, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2020 •
edited
Loading

Codecov Report

Merging #12989 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12989      +/-   ##
==========================================
+ Coverage   42.49%   42.61%   +0.12%     
==========================================
  Files         671      671              
  Lines       73635    73635              
==========================================
+ Hits        31291    31381      +90     
+ Misses      37282    37180     -102     
- Partials     5062     5074      +12
Impacted Files Coverage Δ
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
models/gpg_key.go 53.33% <0.00%> (-0.58%) ⬇️
modules/git/repo.go 46.19% <0.00%> (-0.51%) ⬇️
services/pull/pull.go 40.78% <0.00%> (+0.49%) ⬆️
models/error.go 35.70% <0.00%> (+0.84%) ⬆️
models/notification.go 66.66% <0.00%> (+0.90%) ⬆️
modules/log/event.go 58.49% <0.00%> (+0.94%) ⬆️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️
modules/notification/notification.go 81.25% <0.00%> (+2.67%) ⬆️
modules/notification/base/null.go 71.42% <0.00%> (+2.85%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45727c3...13d185b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 30, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 2, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 2, 2020
@techknowlogick techknowlogick merged commit 5460bf8 into go-gitea:master Oct 2, 2020
@zeripath zeripath deleted the fix-12252-make-bar-groups-responsive branch October 3, 2020 04:20
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Formatting of branches ahead/behind broken on narrow windows
6 participants
@zeripath @codecov-commenter @lafriks @mrsdizzie @techknowlogick @GiteaBot