Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror: Update DB on Address-Update too #12964

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Mirror: Update DB on Address-Update too #12964

merged 2 commits into from
Sep 28, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 28, 2020

fix #12962

@6543 6543 added the type/bug label Sep 28, 2020
@6543 6543 added this to the 1.13.0 milestone Sep 28, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12964 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12964   +/-   ##
=======================================
  Coverage   42.65%   42.66%           
=======================================
  Files         669      669           
  Lines       73493    73494    +1     
=======================================
+ Hits        31351    31354    +3     
+ Misses      37058    37057    -1     
+ Partials     5084     5083    -1
Impacted Files Coverage Δ
services/mirror/mirror.go 18.51% <0.00%> (-0.07%) ⬇️
modules/git/repo_language_stats.go 52.83% <0.00%> (-3.78%) ⬇️
modules/log/event.go 56.60% <0.00%> (-2.84%) ⬇️
services/pull/pull.go 40.78% <0.00%> (ø)
modules/indexer/stats/db.go 60.86% <0.00%> (ø)
models/error.go 34.85% <0.00%> (+0.50%) ⬆️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14e7186...3b0ee1a. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 28, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 28, 2020
@6543
Copy link
Member Author

6543 commented Sep 28, 2020

this may need a backport :D

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 28, 2020
@6543
Copy link
Member Author

6543 commented Sep 28, 2020

🚀

@techknowlogick techknowlogick merged commit 4a654a8 into go-gitea:master Sep 28, 2020
@6543 6543 deleted the fix-update-mirror_update-db-too_12962 branch September 28, 2020 19:04
6543 added a commit to 6543-forks/gitea that referenced this pull request Sep 28, 2020
@6543
Mirror: Update DB on Address-Update too (go-gitea#12964)
0b85b7f 
* Mirror: Update DB on Address-Update too

* new name for function to better describe
@6543 6543 mentioned this pull request Sep 28, 2020
Merged
@6543
Copy link
Member Author

6543 commented Sep 28, 2020

backport -> #12967

@6543 6543 added the backport/done All backports for this PR have been created label Sep 28, 2020
sapk pushed a commit that referenced this pull request Sep 28, 2020
@6543
Mirror: Update DB on Address-Update too (#12964) (#12967)
3e279df 
* Mirror: Update DB on Address-Update too (#12964)

* Mirror: Update DB on Address-Update too

* new name for function to better describe

* fix lint
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

[Bug] "Mirror of X" does not change when updating Clone-URL on Mirror
5 participants
@6543 @codecov-commenter @techknowlogick @zeripath @GiteaBot