Skip to content

Add missing </div> #12924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2020
Merged

Add missing </div> #12924

merged 3 commits into from
Sep 23, 2020

Conversation

@6543
Copy link
Member

@6543 6543 commented Sep 23, 2020 •
edited
Loading

fix #12908

@6543 6543 added backport/done All backports for this PR have been created type/bug labels Sep 23, 2020
@6543 6543 added this to the 1.13.0 milestone Sep 23, 2020
@6543 6543 added topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed backport/done All backports for this PR have been created labels Sep 23, 2020
@6543 6543 mentioned this pull request Sep 23, 2020
Closed
7 tasks
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2020 •
edited
Loading

Codecov Report

Merging #12924 into master will increase coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12924   +/-   ##
=======================================
  Coverage   43.09%   43.09%           
=======================================
  Files         658      658           
  Lines       72454    72455    +1     
=======================================
+ Hits        31221    31223    +2     
+ Misses      36178    36172    -6     
- Partials     5055     5060    +5
Impacted Files Coverage Δ
modules/auth/repo_form.go 42.34% <ø> (ø)
routers/repo/migrate.go 45.29% <25.00%> (+0.47%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/db.go 43.47% <0.00%> (-17.40%) ⬇️
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
modules/git/repo.go 46.19% <0.00%> (-0.51%) ⬇️
services/mirror/mirror.go 19.93% <0.00%> (+1.35%) ⬆️
modules/log/event.go 59.43% <0.00%> (+1.88%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ad714...9f81a68. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 23, 2020
CirnoT
CirnoT reviewed Sep 23, 2020
View reviewed changes
CirnoT
CirnoT reviewed Sep 23, 2020
View reviewed changes
CirnoT
CirnoT reviewed Sep 23, 2020
View reviewed changes
a1012112796
a1012112796 reviewed Sep 23, 2020
View reviewed changes
Copy link
Member

@a1012112796 a1012112796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contain many not usefull changes, suggest recover

@lafriks
Copy link
Member

lafriks commented Sep 23, 2020

would be better to add just </div> and other changes leave for other refactor PR

@6543 6543 force-pushed the fix-repo-create-template branch from 6869153 to 4407336 Compare September 23, 2020 14:05
@6543
Copy link
Member Author

6543 commented Sep 23, 2020

@CirnoT @lafriks @a1012112796 now it only contain fix and the line indentation for that specific block

@6543 6543 changed the title Format & add missing </div> Add missing </div> Sep 23, 2020
a1012112796
a1012112796 approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@a1012112796 a1012112796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 23, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 23, 2020
@6543
Copy link
Member Author

6543 commented Sep 23, 2020

🚀

@jolheiser jolheiser merged commit ba20dd7 into go-gitea:master Sep 23, 2020
@6543 6543 deleted the fix-repo-create-template branch September 24, 2020 01:32
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@CirnoT CirnoT CirnoT approved these changes

@zeripath zeripath zeripath approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

Cannot use Repository template

8 participants

@6543 @codecov-commenter @lafriks @CirnoT @zeripath @a1012112796 @GiteaBot @jolheiser