Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use time/tzdata for timezone in docker #12922

Merged
merged 2 commits into from
Sep 27, 2020

Conversation

sapk
Copy link
Member

@sapk sapk commented Sep 22, 2020

We can remove tzdata of container and use go1.15 in binary timezone.

For details: https://golang.org/doc/go1.15#time/tzdata

@codecov-commenter
Copy link

Codecov Report

Merging #12922 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12922      +/-   ##
==========================================
- Coverage   43.09%   43.07%   -0.02%     
==========================================
  Files         658      658              
  Lines       72454    72454              
==========================================
- Hits        31221    31210      -11     
- Misses      36178    36188      +10     
- Partials     5055     5056       +1     
Impacted Files Coverage Δ
modules/log/event.go 56.60% <0.00%> (-2.84%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
services/pull/pull.go 40.78% <0.00%> (-0.50%) ⬇️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e8bda...301b959. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 22, 2020
@lafriks lafriks added the topic/distribution This PR changes something about the packaging of Gitea label Sep 22, 2020
@lafriks lafriks added this to the 1.14.0 milestone Sep 22, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 22, 2020
@6543
Copy link
Member

6543 commented Sep 23, 2020

any benefits to use build in func?

@sapk
Copy link
Member Author

sapk commented Sep 24, 2020

@6543 it is multiple little improvement:

  • no need to download a package (time and data consuming)
  • simplify/limit arch different comportement
  • less file in image
  • should reduce a little the image size

Those are not great improvement but a step forward to remove external binary and file dependency.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 24, 2020
@zeripath
Copy link
Contributor

Votes for 1.13? I think it's self-contained so can be merged into 1.13 as we build with 1.15.x

@zeripath
Copy link
Contributor

@sapk if you update I think we can merge this in to 1.13

@techknowlogick
Copy link
Member

@sapk can you allow commits from other maintainers to this PR?

@techknowlogick techknowlogick merged commit 14e7186 into go-gitea:master Sep 27, 2020
@techknowlogick techknowlogick modified the milestones: 1.14.0, 1.13.0 Sep 27, 2020
@sapk sapk deleted the use-time-tzdata branch November 3, 2020 08:53
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/distribution This PR changes something about the packaging of Gitea
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants