-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use time/tzdata for timezone in docker #12922
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12922 +/- ##
==========================================
- Coverage 43.09% 43.07% -0.02%
==========================================
Files 658 658
Lines 72454 72454
==========================================
- Hits 31221 31210 -11
- Misses 36178 36188 +10
- Partials 5055 5056 +1
Continue to review full report at Codecov.
|
any benefits to use build in func? |
@6543 it is multiple little improvement:
Those are not great improvement but a step forward to remove external binary and file dependency. |
Votes for 1.13? I think it's self-contained so can be merged into 1.13 as we build with 1.15.x |
@sapk if you update I think we can merge this in to 1.13 |
@sapk can you allow commits from other maintainers to this PR? |
We can remove tzdata of container and use go1.15 in binary timezone.
For details: https://golang.org/doc/go1.15#time/tzdata