Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable migration items when mirror is selected #12918

Merged
merged 3 commits into from
Sep 21, 2020

Conversation

mrsdizzie
Copy link
Member

@mrsdizzie mrsdizzie commented Sep 21, 2020

Disable migration items except wiki when mirror option is selected to make it more clear that it isn't possible to mirror anything other than code.

Screen Shot 2020-09-21 at 12 19 07 PM

Disable migration items when mirror option is selected to make it more clear that it isn't possible to mirror anything other than code.
@techknowlogick techknowlogick added this to the 1.13.0 milestone Sep 21, 2020
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 21, 2020
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps a note that issues etc can’t be selected if mirror used?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 21, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 21, 2020
@jolheiser jolheiser added the topic/ui Change the appearance of the Gitea UI label Sep 21, 2020
@lunny
Copy link
Member

lunny commented Sep 21, 2020

But wiki could be selected?

@mrsdizzie
Copy link
Member Author

@lunny hmm good point! Didn't know that

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2020

Codecov Report

Merging #12918 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12918   +/-   ##
=======================================
  Coverage   43.08%   43.08%           
=======================================
  Files         658      658           
  Lines       72454    72454           
=======================================
+ Hits        31215    31216    +1     
- Misses      36182    36184    +2     
+ Partials     5057     5054    -3     
Impacted Files Coverage Δ
modules/log/event.go 57.54% <0.00%> (-1.89%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
models/error.go 34.81% <0.00%> (-0.52%) ⬇️
models/issue_comment.go 53.75% <0.00%> (-0.16%) ⬇️
routers/repo/view.go 38.11% <0.00%> (+0.64%) ⬆️
services/pull/check.go 47.69% <0.00%> (+0.76%) ⬆️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️
modules/indexer/stats/queue.go 76.47% <0.00%> (+11.76%) ⬆️
modules/indexer/stats/db.go 60.86% <0.00%> (+17.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 060d46d...db09c02. Read the comment docs.

@mrsdizzie
Copy link
Member Author

@lunny fixed now it lets you keep wiki : )

@lafriks lafriks merged commit 63e8bda into go-gitea:master Sep 21, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants