Update only the repository columns that need updating #12900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should only update is_empty, default_branch and updated time columns during commitRepoAction and not update other columns as we risk overwriting incorrect information. Fix go-gitea#11823 Fix go-gitea#10536 Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #12900 +/- ##
=======================================
Coverage 43.08% 43.08%
=======================================
Files 658 658
Lines 72448 72450 +2
=======================================
+ Hits 31211 31215 +4
+ Misses 36183 36179 -4
- Partials 5054 5056 +2
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Sep 19, 2020
GiteaBot
added
lgtm/need 1
6543
approved these changes
Sep 20, 2020
GiteaBot
added
lgtm/done
Member
|
🚀 |
Member
|
@zeripath please send backport:) |
zeripath
deleted the
fix-10536-only-update-correct-cols-in-repository
branch
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Sep 20, 2020
Backport go-gitea#12900 We should only update is_empty, default_branch and updated time columns during commitRepoAction and not update other columns as we risk overwriting incorrect information. Fix go-gitea#11823 Fix go-gitea#10536 Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should only update is_empty, default_branch and updated time columns
during commitRepoAction and not update other columns as we risk
overwriting incorrect information.
Fix #11823
Fix #10536
Signed-off-by: Andrew Thornton art27@cantab.net