-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] add precise search type for Elastic Search #12869
Conversation
Sorry could not decide about version 😆 |
Codecov Report
@@ Coverage Diff @@
## master #12869 +/- ##
==========================================
- Coverage 42.60% 42.59% -0.01%
==========================================
Files 671 671
Lines 73625 73644 +19
==========================================
+ Hits 31366 31369 +3
- Misses 37179 37192 +13
- Partials 5080 5083 +3
Continue to review full report at Codecov.
|
@lafriks committed, thanks! |
Could you add this functionality also for blevesearch as imho it should support it |
This also needs some documentation somewhere, as otherwise there's no way to actually use it without knowing the magic query parameter. |
Added a dropdown in e94a59b for this |
I am not familiar with bleve, need more time to do some research |
ready for review |
ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just small spacing nit
Co-authored-by: Lauris BH <lauris@nix.lv>
Please resolve the conflicts. |
ready for review |
Codecov Report
@@ Coverage Diff @@
## master #12869 +/- ##
=======================================
Coverage 42.11% 42.11%
=======================================
Files 758 758
Lines 81085 81104 +19
=======================================
+ Hits 34148 34157 +9
- Misses 41360 41369 +9
- Partials 5577 5578 +1
Continue to review full report at Codecov.
|
Added a query parameter
t=match
on/explore/code
and/repo/search
, which add precise search feature for code search with Elastic Search.