Skip to content

Fix anonymous GL migration #12862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 15, 2020
Merged

Fix anonymous GL migration #12862

merged 3 commits into from
Sep 15, 2020

Conversation

@jolheiser
Copy link
Member

@jolheiser jolheiser commented Sep 15, 2020

Using basic auth will fail as the GL client wants to get an OAuth token, which fails with invalid basic auth.

Using a blank token allows anonymous usage, however.

@jolheiser
Fix anonymous GL migration
3d8cdab 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser
Rely on password instead
410fad9 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser added this to the 1.13.0 milestone Sep 15, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 15, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 15, 2020
@techknowlogick
Copy link
Member

techknowlogick commented Sep 15, 2020

🚀

@techknowlogick techknowlogick merged commit d9085fe into go-gitea:master Sep 15, 2020
@jolheiser jolheiser deleted the fix-gl branch September 15, 2020 19:32
@6543 6543 mentioned this pull request Oct 11, 2020
Merged
zeripath pushed a commit that referenced this pull request Oct 12, 2020
@6543
Backport Migration Option AuthToken (#13101)
f9942ad 
fix #13085

Backport #12862
Backport Parts of #12672
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@6543 6543 6543 approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jolheiser @techknowlogick @zeripath @6543 @GiteaBot