Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CheckUnitUser logic #12854

Merged
merged 3 commits into from
Sep 15, 2020
Merged

Conversation

a1012112796
Copy link
Member

if check one user's unit in different repos, it's not necessary to get user data every time.

if check one user's unit in different repos, it's not necessary to
get user data every time.

Signed-off-by: a1012112796 <1012112796@qq.com>
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 15, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 15, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2020

Codecov Report

Merging #12854 into master will decrease coverage by 0.02%.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12854      +/-   ##
==========================================
- Coverage   43.11%   43.08%   -0.03%     
==========================================
  Files         655      655              
  Lines       72328    72329       +1     
==========================================
- Hits        31186    31165      -21     
- Misses      36094    36111      +17     
- Partials     5048     5053       +5     
Impacted Files Coverage Δ
routers/home.go 47.50% <0.00%> (+0.36%) ⬆️
models/notification.go 65.83% <57.14%> (-1.22%) ⬇️
models/repo.go 55.54% <80.00%> (-0.15%) ⬇️
routers/repo/repo.go 28.46% <100.00%> (ø)
models/repo_mirror.go 2.38% <0.00%> (-11.91%) ⬇️
modules/cron/tasks_basic.go 87.35% <0.00%> (-3.45%) ⬇️
modules/notification/mail/mail.go 34.48% <0.00%> (-3.45%) ⬇️
modules/notification/ui/ui.go 80.55% <0.00%> (-2.78%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
services/pull/check.go 47.69% <0.00%> (-2.31%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07995e2...1a31810. Read the comment docs.

@6543 6543 added this to the 1.13.0 milestone Sep 15, 2020
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect there are lots more improvements possible here.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 15, 2020
@techknowlogick techknowlogick merged commit ec5677b into go-gitea:master Sep 15, 2020
@a1012112796 a1012112796 deleted the simplify_logic branch October 24, 2020 02:35
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants