Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [API] [Bug] CreateRepo missing information #12848

Merged
merged 6 commits into from
Sep 15, 2020
Merged

Fix [API] [Bug] CreateRepo missing information #12848

merged 6 commits into from
Sep 15, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 15, 2020

close #12748

@6543 6543 added modifies/api This PR adds API routes or modifies them type/bug labels Sep 15, 2020
@6543 6543 added this to the 1.13.0 milestone Sep 15, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2020 •
edited
Loading

Codecov Report

Merging #12848 into master will decrease coverage by 0.07%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12848      +/-   ##
==========================================
- Coverage   43.11%   43.04%   -0.08%     
==========================================
  Files         655      655              
  Lines       72325    72328       +3     
==========================================
- Hits        31185    31131      -54     
- Misses      36099    36152      +53     
- Partials     5041     5045       +4
Impacted Files Coverage Δ
routers/api/v1/repo/repo.go 61.58% <33.33%> (-0.24%) ⬇️
services/pull/check.go 31.53% <0.00%> (-18.47%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-6.75%) ⬇️
modules/notification/ui/ui.go 80.55% <0.00%> (-2.78%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/log/event.go 57.54% <0.00%> (-1.89%) ⬇️
services/gitdiff/gitdiff.go 72.85% <0.00%> (-1.64%) ⬇️
models/notification.go 66.13% <0.00%> (-0.92%) ⬇️
models/repo_list.go 78.57% <0.00%> (-0.90%) ⬇️
models/error.go 34.81% <0.00%> (-0.86%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 772b5e0...2574922. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 15, 2020
lunny
lunny approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to add a comment there to explain why we reload the repository from the database.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 15, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 15, 2020
@techknowlogick techknowlogick merged commit 07995e2 into go-gitea:master Sep 15, 2020
@6543 6543 deleted the fix-api-CreateRepo_12748 branch September 15, 2020 22:45
6543 added a commit to 6543-forks/gitea that referenced this pull request Sep 15, 2020
@6543 @lunny
Fix [API] [Bug] CreateRepo missing information (go-gitea#12848)
4f7a306 
* Fix [API] [Bug] CreateRepo missing information

* add code comment

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@6543 6543 mentioned this pull request Sep 15, 2020
Merged
@6543 6543 added backport/done All backports for this PR have been created backport/v1.12 labels Sep 15, 2020
lunny added a commit that referenced this pull request Sep 18, 2020
@6543 @lunny @zeripath
Fix [API] CreateRepo missing information (#12848) (#12867)
869fd17 
* Fix [API] [Bug] CreateRepo missing information (#12848)

* Fix [API] [Bug] CreateRepo missing information

* add code comment

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

* CI.restart()

* CI.restart()

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CirnoT CirnoT CirnoT approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

[API] [Bug] CreateRepo missing information
6 participants
@6543 @codecov-commenter @lunny @CirnoT @techknowlogick @GiteaBot