Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitea.com/macaron/i18n #12806

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Sep 10, 2020

Prevents the panic on missing locale files.

Fixes #1014

Signed-off-by: Andrew Thornton art27@cantab.net

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.13.0 milestone Sep 10, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12806 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12806      +/-   ##
==========================================
- Coverage   43.22%   43.20%   -0.03%     
==========================================
  Files         651      651              
  Lines       72118    72118              
==========================================
- Hits        31174    31158      -16     
- Misses      35902    35912      +10     
- Partials     5042     5048       +6     
Impacted Files Coverage Δ
modules/notification/mail/mail.go 34.48% <0.00%> (-3.45%) ⬇️
modules/notification/ui/ui.go 80.55% <0.00%> (-2.78%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
services/pull/check.go 47.69% <0.00%> (-2.31%) ⬇️
models/notification.go 66.13% <0.00%> (-0.92%) ⬇️
models/error.go 34.81% <0.00%> (-0.86%) ⬇️
services/pull/pull.go 41.57% <0.00%> (-0.47%) ⬇️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
modules/indexer/stats/db.go 69.56% <0.00%> (+8.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4728934...8a0fce6. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 10, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 10, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 10, 2020
@jolheiser jolheiser merged commit daefdd1 into go-gitea:master Sep 10, 2020
@zeripath zeripath deleted the update-macaron-i18n branch September 10, 2020 21:49
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic on self built gitea version v1.0.2
5 participants