Add migration for password algorithm change #12784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-gitea#12688 changed the default for the user table leading to sync2 warnings Unfortunately changing defaults requires a complete table rewrite in general. However, just dropping columns could be bad - so this PR leverages the techniques used in recreate table to recreate from the inferred schema and recreates the user table. This is not necessarily the correct thing to do - but code sometimes speaks louder than words. Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
commented
Sep 9, 2020
GiteaBot
added
the
lgtm/need 2
zeripath
commented
Sep 9, 2020
Member
|
Tested, worked for me. |
This comment has been minimized.
This comment has been minimized.
Member
|
Maybe it's worth to move some of the code to (future) shared function? |
Signed-off-by: Andrew Thornton <art27@cantab.net>
Contributor
Author
|
OK the indices are correct for the user table |
Codecov Report
@@ Coverage Diff @@
## master #12784 +/- ##
==========================================
- Coverage 43.16% 43.08% -0.08%
==========================================
Files 654 655 +1
Lines 72200 72325 +125
==========================================
Hits 31163 31163
- Misses 35986 36117 +131
+ Partials 5051 5045 -6
Continue to review full report at Codecov.
|
Member
|
@zeripath does recreateTable not cover this case? |
Contributor
Author
|
It's an option. I thought I'd write this to show what a non-recreate table solution looks like - this one means that any columns that are excess will not be deleted. Happy to drop the SQLite3 solution to use recreateTable though. |
6543
reviewed
Sep 10, 2020
6543
approved these changes
Sep 10, 2020
GiteaBot
added
lgtm/need 1
mrsdizzie
approved these changes
Sep 11, 2020
GiteaBot
added
lgtm/done
Member
|
please resolve conflicts |
lunny
reviewed
Sep 12, 2020
Signed-off-by: Andrew Thornton <art27@cantab.net>
lafriks
approved these changes
Sep 15, 2020
Member
|
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12688 changed the default for the user table leading to sync2 warnings
Unfortunately changing defaults requires a complete table rewrite in general.
However, just dropping columns could be bad - so this PR leverages the
techniques used in recreate table to recreate from the inferred schema
and recreates the user table.
This is not necessarily the correct thing to do - but code sometimes speaks
louder than words.
Signed-off-by: Andrew Thornton art27@cantab.net