Only use async pre-empt hack if go < 1.15 #12718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
the
type/feature
| @@ -130,7 +132,9 @@ func (c *Command) RunInDirTimeoutEnvFullPipelineFunc(env []string, timeout time. | |||
| } | |||
|
|
|||
| // TODO: verify if this is still needed in golang 1.15 | |||
There was a problem hiding this comment.
Suggested change
| // TODO: verify if this is still needed in golang 1.15 |
There was a problem hiding this comment.
perhaps we should actually verify it first... 😛
GiteaBot
added
the
lgtm/need 2
6543
reviewed
Sep 4, 2020
| "strings" | ||
| "time" | ||
|
|
||
| "code.gitea.io/gitea/modules/process" | ||
| "github.com/mcuadros/go-version" |
There was a problem hiding this comment.
github.com/mcuadros/go-version was archived !!!
we should switch to github.com/hashicorp/go-version
There was a problem hiding this comment.
I'll try to create a pr - it shold be a drop in replacement ...
Codecov Report
@@ Coverage Diff @@
## master #12718 +/- ##
==========================================
+ Coverage 43.29% 43.31% +0.02%
==========================================
Files 646 646
Lines 71592 71625 +33
==========================================
+ Hits 30993 31022 +29
+ Misses 35583 35581 -2
- Partials 5016 5022 +6
Continue to review full report at Codecov.
|
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Sep 4, 2020
GiteaBot
added
lgtm/done
6543
added
type/enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.15 should have fixed the problems requiring setting GODEBUG=asyncpreempt=off. Therefore if we are running 1.15 we don't need to set this.
Signed-off-by: Andrew Thornton art27@cantab.net