Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Expose its limitation settings #12714

Merged

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 4, 2020

close #12664

Copy link
Member

@mrsdizzie mrsdizzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the new settings API should get tests at some point : )

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 4, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 4, 2020
@6543
Copy link
Member Author

6543 commented Sep 4, 2020

Lable kind/api needed and milestone

@techknowlogick techknowlogick added the modifies/api This PR adds API routes or modifies them label Sep 4, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Sep 4, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12714 into master will decrease coverage by 0.00%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12714      +/-   ##
==========================================
- Coverage   43.31%   43.31%   -0.01%     
==========================================
  Files         646      646              
  Lines       71616    71624       +8     
==========================================
+ Hits        31022    31025       +3     
- Misses      35577    35580       +3     
- Partials     5017     5019       +2     
Impacted Files Coverage Δ
routers/api/v1/settings/settings.go 25.00% <0.00%> (-19.45%) ⬇️
routers/api/v1/api.go 79.04% <100.00%> (+0.03%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
modules/notification/mail/mail.go 34.48% <0.00%> (-3.45%) ⬇️
modules/notification/ui/ui.go 80.55% <0.00%> (-2.78%) ⬇️
models/notification.go 66.13% <0.00%> (-0.92%) ⬇️
models/error.go 35.32% <0.00%> (-0.35%) ⬇️
models/issue_comment.go 53.90% <0.00%> (+0.15%) ⬆️
services/pull/pull.go 42.03% <0.00%> (+0.46%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e710a34...573af6b. Read the comment docs.

@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 2a52aee into go-gitea:master Sep 4, 2020
@6543 6543 deleted the api_expose-limitation-settings branch September 4, 2020 19:11
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Expose MAX_RESPONSE_ITEMS for API
6 participants