Skip to content

Conversation

@6543
Copy link
Member

@6543 6543 commented Sep 3, 2020

as title

and adapt breaking changes (2d05d08)

@6543 6543 changed the title [Vendor] Update xanzy/go-gitlab v0.31.0 => v0.37.0 [WIP] [Vendor] Update xanzy/go-gitlab v0.31.0 => v0.37.0 Sep 3, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2020

Codecov Report

Merging #12701 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12701      +/-   ##
==========================================
- Coverage   43.40%   43.39%   -0.01%     
==========================================
  Files         648      648              
  Lines       71581    71581              
==========================================
- Hits        31072    31066       -6     
  Misses      35482    35482              
- Partials     5027     5033       +6     
Impacted Files Coverage Δ
modules/migrations/gitlab.go 1.04% <0.00%> (ø)
modules/notification/mail/mail.go 34.48% <0.00%> (-3.45%) ⬇️
modules/notification/ui/ui.go 80.55% <0.00%> (-2.78%) ⬇️
services/pull/check.go 47.69% <0.00%> (-2.31%) ⬇️
modules/log/event.go 57.54% <0.00%> (-1.89%) ⬇️
models/notification.go 66.13% <0.00%> (-0.92%) ⬇️
models/error.go 34.81% <0.00%> (-0.86%) ⬇️
routers/repo/view.go 37.98% <0.00%> (+0.64%) ⬆️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️
modules/queue/workerpool.go 62.04% <0.00%> (+3.26%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed5e10...42b85d6. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 4, 2020
@6543 6543 changed the title [WIP] [Vendor] Update xanzy/go-gitlab v0.31.0 => v0.37.0 [Vendor] Update xanzy/go-gitlab v0.31.0 => v0.37.0 Sep 4, 2020
@6543
Copy link
Member Author

6543 commented Sep 4, 2020

@techknowlogick yes this was it ... go1.13 was needed

@6543 6543 added dependencies skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Sep 5, 2020
@6543 6543 added this to the 1.14.0 milestone Sep 5, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 5, 2020
@lunny
Copy link
Member

lunny commented Sep 6, 2020

@6543 Please resolve the conflicts. I think this could be moved to v1.13 if it's ready to merge in time.

@6543 6543 modified the milestones: 1.14.0, 1.13.0 Sep 6, 2020
@6543
Copy link
Member Author

6543 commented Sep 6, 2020

@lunny done

@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 0c6a802 into go-gitea:master Sep 6, 2020
@techknowlogick techknowlogick added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 6, 2020
@6543 6543 deleted the vendor-update_go-gitlab branch September 6, 2020 16:11
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants