-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a migrate service type switch page #12697
Conversation
Why no mirror for github/gitlab? |
The darker colors on the darker background is a little hard to read imo @mrsdizzie My guess is because mirroring doesn't copy items |
Icons seem too huge based on that screenshot. Maybe add some padding like 2rem to the icons, keeping the box size or maybe reducing it slightly? Also, the GitHub icon should be inverted in the dark theme. |
Also, I'd suggest using SVG icons over PNG. You can put them in |
by the way: token auth field is always deactivated + js could be simplfied since now most option(-hides) are handled by template |
Hmm I think this makes the current interface more confusing then: If a user wants to mirror something from Github they are going to click the giant Github icon first. Figuring out that you need to go back and click the one that is not Github in order to set up a mirror to a Github hosted repo seems more confusing than the current form. When you click on plain Git there is no option to use a token -- but that will be required for mirroring some repos on Github. So this would remove the option to mirror a private repo hosted on Github at some point? I think we would want the same logic for tokens when it comes to a mirror as well. I see the difference between mirroring and migrating files but that is pretty subtle considering we already put mirroring in the section labeled migrations. Looks nice otherwise : ) |
How about to add a new icon named |
@lunny I think we should add them back because it will want to use a token as well and it will be less confusing to keep anything related to github/gitlab behind their logos looks nice though! |
5ed9739
to
918bd0f
Compare
@mrsdizzie @silverwind @jolheiser Done. |
Codecov Report
@@ Coverage Diff @@
## master #12697 +/- ##
==========================================
- Coverage 43.26% 43.24% -0.02%
==========================================
Files 649 650 +1
Lines 72046 72041 -5
==========================================
- Hits 31169 31156 -13
Misses 35838 35838
- Partials 5039 5047 +8
Continue to review full report at Codecov.
|
e9b5c80
to
5a4a8b1
Compare
@mrsdizzie Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤
@mrsdizzie done. |
When clicking
New Migration
, it will enter a new page to let users chose which Git service they want to migrate from.Chose Git will let you migrate git data or mirror git data from any possible git services via http/https protocol or local disk if enabled.
Chose GitHub will let user migrate git/issues ... and etc. data from Github or Github Enterprise
Chose GitLab will let user migrate git/issues ... and etc. data from GitLab.com or self-hosted Gitlab