Skip to content

Conversation

@6543
Copy link
Member

@6543 6543 commented Sep 3, 2020

as title

include #12693

@6543 6543 changed the title Migrations: Gitlab Add Awards Support for Issues & MergeRequests Migrations: Gitlab Add Reactions Support for Issues & MergeRequests Sep 3, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 3, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2020

Codecov Report

Merging #12695 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12695      +/-   ##
==========================================
- Coverage   43.33%   43.30%   -0.04%     
==========================================
  Files         645      645              
  Lines       71531    71560      +29     
==========================================
- Hits        30998    30986      -12     
- Misses      35514    35555      +41     
  Partials     5019     5019              
Impacted Files Coverage Δ
modules/migrations/gitlab.go 1.04% <0.00%> (-0.09%) ⬇️
models/repo_mirror.go 2.38% <0.00%> (-11.91%) ⬇️
modules/cron/tasks_basic.go 87.35% <0.00%> (-3.45%) ⬇️
modules/queue/workerpool.go 56.73% <0.00%> (-3.27%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
services/mirror/mirror.go 18.58% <0.00%> (-1.36%) ⬇️
models/issue_comment.go 53.75% <0.00%> (-0.16%) ⬇️
services/pull/pull.go 41.57% <0.00%> (ø)
modules/indexer/stats/db.go 52.17% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7af2ccd...0746964. Read the comment docs.

Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 3, 2020
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Sep 3, 2020
@lafriks lafriks added this to the 1.13.0 milestone Sep 3, 2020
@lafriks lafriks merged commit ad4a644 into go-gitea:master Sep 3, 2020
@lafriks lafriks deleted the migration-gitlab_add-Awards branch September 3, 2020 07:35
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants