Skip to content

Conversation

@6543
Copy link
Member

@6543 6543 commented Aug 31, 2020

close #12655

@6543 6543 force-pushed the Add_Created-Updated-Milestone_12655 branch from de9c244 to b01768e Compare August 31, 2020 13:17
@6543 6543 force-pushed the Add_Created-Updated-Milestone_12655 branch from b01768e to 2e5930e Compare August 31, 2020 13:20
@a1012112796

This comment has been minimized.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 31, 2020
@6543
Copy link
Member Author

6543 commented Aug 31, 2020

@a1012112796 this would be a lot of extra SQL querys on each milestone related thing ...

@a1012112796

This comment has been minimized.

@a1012112796
Copy link
Member

Suggest show it on ui also.
image

@6543 6543 changed the title Add Created & Updated to Milestone WIP: Add Created & Updated to Milestone Aug 31, 2020
@6543
Copy link
Member Author

6543 commented Sep 1, 2020

@a1012112796 I think it will get to overloaded with this:
Bildschirmfoto zu 2020-09-01 04-45-33

@6543 6543 changed the title WIP: Add Created & Updated to Milestone Add Created & Updated to Milestone Sep 1, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020

Codecov Report

Merging #12662 into master will decrease coverage by 0.04%.
The diff coverage is 53.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12662      +/-   ##
==========================================
- Coverage   43.40%   43.36%   -0.05%     
==========================================
  Files         647      648       +1     
  Lines       71500    71534      +34     
==========================================
- Hits        31038    31022      -16     
- Misses      35443    35480      +37     
- Partials     5019     5032      +13     
Impacted Files Coverage Δ
models/migrations/migrations.go 4.66% <ø> (ø)
models/migrations/v149.go 0.00% <0.00%> (ø)
modules/git/repo_attribute.go 0.00% <0.00%> (ø)
modules/git/repo_tag.go 61.68% <ø> (-0.25%) ⬇️
modules/git/repo_tree.go 40.00% <0.00%> (ø)
routers/admin/admin.go 11.45% <0.00%> (-0.04%) ⬇️
routers/repo/lfs.go 0.00% <0.00%> (ø)
services/mirror/mirror.go 18.58% <0.00%> (ø)
modules/git/git.go 40.00% <50.00%> (+2.33%) ⬆️
modules/setting/setting.go 46.81% <50.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7404786...a1fe227. Read the comment docs.

Copy link
Member

@a1012112796 a1012112796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@techknowlogick techknowlogick added this to the 1.13.0 milestone Sep 1, 2020
@6543 6543 added modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Sep 5, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 5, 2020
@techknowlogick techknowlogick merged commit 1ea1cad into go-gitea:master Sep 5, 2020
@6543 6543 deleted the Add_Created-Updated-Milestone_12655 branch September 5, 2020 18:28
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API] Milestone expose Times

6 participants