Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip SSPI authentication attempts for /api/internal #12556

Merged
merged 4 commits into from
Aug 22, 2020
Merged

Skip SSPI authentication attempts for /api/internal #12556

merged 4 commits into from
Aug 22, 2020

Conversation

zeripath
Copy link
Contributor

SSPI fails badly on authentication attempts to /api/internal which
it can never succesfully authenticate.

Fix #11260

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Skip SSPI authentication attempts for /api/internal
2f1ed00 
SSPI fails badly on authentication attempts to /api/internal which
it can never succesfully authenticate.

Fix go-gitea#11260

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.13.0 milestone Aug 21, 2020
@zeripath
Copy link
Contributor Author

Grr golangci-lint the code is not unused it's just only used on a Windows variant!!

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 21, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2020 •
edited
Loading

Codecov Report

Merging #12556 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12556      +/-   ##
==========================================
- Coverage   43.44%   43.42%   -0.03%     
==========================================
  Files         643      643              
  Lines       71155    71157       +2     
==========================================
- Hits        30915    30901      -14     
- Misses      35235    35247      +12     
- Partials     5005     5009       +4
Impacted Files Coverage Δ
modules/auth/sso/oauth2.go 46.77% <100.00%> (-14.52%) ⬇️
modules/auth/sso/sso.go 32.72% <100.00%> (+2.53%) ⬆️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
models/oauth2_application.go 68.84% <0.00%> (-0.77%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-0.51%) ⬇️
services/pull/pull.go 41.57% <0.00%> (-0.47%) ⬇️
modules/indexer/stats/db.go 60.86% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4e35b9...5322119. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 21, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 22, 2020
@lafriks lafriks merged commit b78448e into go-gitea:master Aug 22, 2020
@lafriks
Copy link
Member

lafriks commented Aug 22, 2020

Please send backport

@zeripath zeripath deleted the fix-11260-do-internal-authentication-first branch August 22, 2020 10:44
@zeripath
Copy link
Contributor Author

Oh I think I have a few waiting ...

zeripath added a commit to zeripath/gitea that referenced this pull request Aug 22, 2020
@zeripath
Skip SSPI authentication attempts for /api/internal (go-gitea#12556)
874a567 
Backport go-gitea#12556

SSPI fails badly on authentication attempts to /api/internal which
it can never succesfully authenticate.

Fix go-gitea#11260

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Aug 22, 2020
Merged
@zeripath zeripath added the backport/done All backports for this PR have been created label Aug 22, 2020
techknowlogick pushed a commit that referenced this pull request Aug 22, 2020
@zeripath @lafriks
Skip SSPI authentication attempts for /api/internal (#12556) (#12559)
8bf2ee1 
Backport #12556

SSPI fails badly on authentication attempts to /api/internal which
it can never succesfully authenticate.

Fix #11260

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Internal SSH fails when SSPI Auth enabled
5 participants
@zeripath @codecov-commenter @lafriks @techknowlogick @GiteaBot