Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set z-index for sticky diff box lower #12537

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

zeripath
Copy link
Contributor

Fix #12525

As per @CirnoT comments on that issue.

Signed-off-by: Andrew Thornton art27@cantab.net

Fix go-gitea#12525

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Aug 19, 2020
@zeripath zeripath added this to the 1.13.0 milestone Aug 19, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12537 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12537      +/-   ##
==========================================
- Coverage   43.50%   43.50%   -0.01%     
==========================================
  Files         642      642              
  Lines       71003    71003              
==========================================
- Hits        30892    30891       -1     
+ Misses      35105    35103       -2     
- Partials     5006     5009       +3     
Impacted Files Coverage Δ
modules/indexer/stats/queue.go 52.94% <0.00%> (-23.53%) ⬇️
modules/indexer/stats/db.go 43.47% <0.00%> (-8.70%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-0.51%) ⬇️
services/pull/pull.go 41.57% <0.00%> (-0.47%) ⬇️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
modules/log/event.go 59.43% <0.00%> (+1.88%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ca652c...86f0474. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 19, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 19, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 19, 2020
@jolheiser jolheiser merged commit 1701d57 into go-gitea:master Aug 19, 2020
@zeripath zeripath deleted the fix-12525-sticky-lower branch August 19, 2020 21:47
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can’t choose branch for merge.
6 participants