Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded ES indexername #12521

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Remove hardcoded ES indexername #12521

merged 1 commit into from
Aug 18, 2020

Conversation

42wim
Copy link
Member

@42wim 42wim commented Aug 18, 2020

This makes the ISSUE_INDEXER_NAME option actually work

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 18, 2020
@lunny
Copy link
Member

lunny commented Aug 18, 2020

We also need to add version check on elastic search.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 18, 2020
@lunny lunny added this to the 1.13.0 milestone Aug 18, 2020
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Aug 18, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12521 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12521      +/-   ##
==========================================
- Coverage   43.51%   43.51%   -0.01%     
==========================================
  Files         642      642              
  Lines       71003    71003              
==========================================
- Hits        30899    30898       -1     
- Misses      35098    35103       +5     
+ Partials     5006     5002       -4     
Impacted Files Coverage Δ
modules/indexer/issues/indexer.go 58.46% <100.00%> (ø)
modules/indexer/stats/queue.go 52.94% <0.00%> (-23.53%) ⬇️
modules/indexer/stats/db.go 43.47% <0.00%> (-8.70%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
routers/repo/view.go 37.33% <0.00%> (-0.65%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-0.51%) ⬇️
models/gpg_key.go 55.17% <0.00%> (+0.59%) ⬆️
services/pull/pull.go 42.72% <0.00%> (+0.69%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61a1729...9da2622. Read the comment docs.

@jolheiser jolheiser merged commit e14f608 into go-gitea:master Aug 18, 2020
jolheiser pushed a commit to jolheiser/gitea that referenced this pull request Aug 18, 2020
@jolheiser jolheiser added the backport/done All backports for this PR have been created label Aug 18, 2020
techknowlogick pushed a commit that referenced this pull request Aug 19, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants