Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not add prefix on http/https submodule links #12477

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Do not add prefix on http/https submodule links #12477

merged 1 commit into from
Aug 13, 2020

Conversation

zeripath
Copy link
Contributor

Fix #12345

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Do not add prefix on http/https submodule links
6028356 
Fix go-gitea#12345

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.13.0 milestone Aug 12, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12477 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12477      +/-   ##
==========================================
+ Coverage   43.77%   43.80%   +0.03%     
==========================================
  Files         631      631              
  Lines       69851    69851              
==========================================
+ Hits        30576    30597      +21     
+ Misses      34325    34311      -14     
+ Partials     4950     4943       -7
Impacted Files Coverage Δ
modules/git/submodule.go 74.00% <100.00%> (ø)
modules/indexer/stats/queue.go 52.94% <0.00%> (-11.77%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/queue/workerpool.go 60.00% <0.00%> (-2.05%) ⬇️
models/issue_comment.go 55.11% <0.00%> (ø)
services/pull/pull.go 42.95% <0.00%> (+0.23%) ⬆️
models/issue.go 57.14% <0.00%> (+0.35%) ⬆️
modules/git/repo.go 52.28% <0.00%> (+0.50%) ⬆️
modules/notification/webhook/webhook.go 48.95% <0.00%> (+0.52%) ⬆️
modules/git/command.go 90.19% <0.00%> (+1.96%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e1c7cc...6028356. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 12, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 13, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 13, 2020
@techknowlogick techknowlogick merged commit be1b33c into go-gitea:master Aug 13, 2020
techknowlogick pushed a commit to techknowlogick/gitea that referenced this pull request Aug 13, 2020
@zeripath @techknowlogick
Do not add prefix on http/https submodule links (go-gitea#12477)
a90b52b 
Fix go-gitea#12345

Signed-off-by: Andrew Thornton <art27@cantab.net>
@techknowlogick techknowlogick mentioned this pull request Aug 13, 2020
Merged
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Aug 13, 2020
@zeripath zeripath deleted the fix-12345-submodule-redux branch August 13, 2020 15:23
techknowlogick added a commit that referenced this pull request Aug 13, 2020
@techknowlogick @zeripath
Do not add prefix on http/https submodule links (#12477) (#12479)
f0dd071 
Fix #12345

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

wrong url for submodule when using reverse proxy in 1.11 and newer
5 participants
@zeripath @codecov-commenter @lunny @techknowlogick @GiteaBot