Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go1.15 #12475

Merged
merged 9 commits into from
Aug 13, 2020
Merged

go1.15 #12475

merged 9 commits into from
Aug 13, 2020

Conversation

techknowlogick
Copy link
Member

as title

@techknowlogick techknowlogick added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Aug 11, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Aug 11, 2020
@lafriks
Copy link
Member

lafriks commented Aug 11, 2020

Build failing

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 11, 2020
@techknowlogick
Copy link
Member Author

@lafriks blocked by upstream docker images

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2020

Codecov Report

Merging #12475 into master will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12475      +/-   ##
==========================================
- Coverage   43.77%   43.72%   -0.06%     
==========================================
  Files         631      631              
  Lines       69851    69851              
==========================================
- Hits        30576    30541      -35     
- Misses      34325    34362      +37     
+ Partials     4950     4948       -2     
Impacted Files Coverage Δ
modules/git/command.go 88.23% <ø> (ø)
modules/public/public.go 56.16% <0.00%> (ø)
services/pull/check.go 31.53% <0.00%> (-18.47%) ⬇️
modules/indexer/stats/queue.go 52.94% <0.00%> (-11.77%) ⬇️
services/pull/update.go 51.92% <0.00%> (-5.77%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-3.27%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
modules/git/repo.go 49.74% <0.00%> (-2.04%) ⬇️
services/pull/pull.go 42.03% <0.00%> (-0.70%) ⬇️
models/pull.go 54.54% <0.00%> (-0.63%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e1c7cc...17d3c78. Read the comment docs.

@lunny
Copy link
Member

lunny commented Aug 12, 2020

I would like to upgrade after v1.15.1 is released. :(

@go-gitea go-gitea deleted a comment from lunny Aug 12, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 13, 2020
@CirnoT
Copy link
Contributor

CirnoT commented Aug 13, 2020

@lunny I don't see a need to wait for .1 release given that this is not backportable change and we'll have more time and chances to catch potential issues before Gitea 1.13 is done.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 13, 2020
@techknowlogick
Copy link
Member Author

🚀

@techknowlogick techknowlogick merged commit bd7d6a3 into go-gitea:master Aug 13, 2020
@techknowlogick techknowlogick deleted the go1.15 branch August 13, 2020 14:11
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants