Skip to content

Refactor and fix incorrect comment #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2017
Merged

Refactor and fix incorrect comment #1247

merged 1 commit into from
Mar 15, 2017

Conversation

@ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Mar 14, 2017 •
edited
Loading

  • Replace the *User arguments to [aA]ccessLevel(..), [hH]asAccess(..) to int64 userID arguments to avoid unnecessary loads
  • Fix incorrect specifications for AccessLevel(..) HasAccess(..)
  • Add a getTeamUsersByTeamID(..) helper function to avoid unnecessary loads

lunny
lunny requested changes Mar 14, 2017
View reviewed changes
models/access.go Outdated
Copy link
Member

@lunny lunny Mar 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if userID == 0 ?

Copy link
Member Author

@ethantkoenig ethantkoenig Mar 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added back.

@lunny
Copy link
Member

lunny commented Mar 14, 2017

LGTM

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 14, 2017
@lunny lunny added this to the 1.2.0 milestone Mar 14, 2017
@lunny lunny added type/refactoring Existing code has been cleaned up. There should be no new functionality. type/docs This PR mainly updates/creates documentation labels Mar 14, 2017
@appleboy
Copy link
Member

appleboy commented Mar 14, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 14, 2017
@lunny lunny merged commit ec0ae5d into go-gitea:master Mar 15, 2017
@ethantkoenig ethantkoenig deleted the refactor/access branch March 15, 2017 00:53
@ethantkoenig ethantkoenig mentioned this pull request Mar 15, 2017
Merged
@snyk-bot snyk-bot mentioned this pull request Nov 18, 2020
Open
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ethantkoenig @lunny @appleboy @tboerger