-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add placeholder text for send testing email button in admin/config #12452
Add placeholder text for send testing email button in admin/config #12452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR. For accessibility placeholders aren’t supposed to be used for instructions, but rather labels associated with input fields are (screen readers may not read out the placeholder)
As well could You update this to make the string able to be translated to other languages?
I prefer example values, e.g. MDN says:
|
ok Co-authored-by: silverwind <me@silverwind.io>
Codecov Report
@@ Coverage Diff @@
## master #12452 +/- ##
==========================================
- Coverage 43.81% 43.80% -0.01%
==========================================
Files 630 630
Lines 69821 69821
==========================================
- Hits 30589 30587 -2
- Misses 34297 34299 +2
Partials 4935 4935
Continue to review full report at Codecov.
|
As title.
Input box for
Send testing email
in admin/config doesn't have any text guidance for correct usage. This PR add such in form ofplaceholder
attribute.Screenshot: