Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder text for send testing email button in admin/config #12452

Conversation

bagasme
Copy link
Contributor

@bagasme bagasme commented Aug 7, 2020

As title.

Input box for Send testing email in admin/config doesn't have any text guidance for correct usage. This PR add such in form of placeholder attribute.

Screenshot:
placeholder text guide

Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR. For accessibility placeholders aren’t supposed to be used for instructions, but rather labels associated with input fields are (screen readers may not read out the placeholder)

As well could You update this to make the string able to be translated to other languages?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 7, 2020
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Aug 7, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Aug 7, 2020
@silverwind
Copy link
Member

silverwind commented Aug 7, 2020

I prefer example values, e.g. user@example.com. I don't think we need to localize that.

MDN says:

The placeholder attribute is a string that provides a brief hint to the user as to what kind of information is expected in the field. It should be a word or short phrase that demonstrates the expected type of data, rather than an explanatory message.

ok

Co-authored-by: silverwind <me@silverwind.io>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 9, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 9, 2020
@techknowlogick techknowlogick dismissed their stale review August 9, 2020 19:01

dismissing my review

@codecov-commenter
Copy link

Codecov Report

Merging #12452 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12452      +/-   ##
==========================================
- Coverage   43.81%   43.80%   -0.01%     
==========================================
  Files         630      630              
  Lines       69821    69821              
==========================================
- Hits        30589    30587       -2     
- Misses      34297    34299       +2     
  Partials     4935     4935              
Impacted Files Coverage Δ
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
modules/git/repo.go 51.26% <0.00%> (-1.02%) ⬇️
modules/log/event.go 56.60% <0.00%> (-0.95%) ⬇️
modules/notification/webhook/webhook.go 48.43% <0.00%> (-0.53%) ⬇️
models/issue.go 56.78% <0.00%> (-0.36%) ⬇️
services/pull/pull.go 43.41% <0.00%> (-0.24%) ⬇️
models/repo.go 55.71% <0.00%> (+0.15%) ⬆️
modules/indexer/stats/db.go 60.86% <0.00%> (+17.39%) ⬆️
modules/indexer/stats/queue.go 76.47% <0.00%> (+23.52%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cc21fb...e3c01e1. Read the comment docs.

@techknowlogick techknowlogick merged commit a4ba1ad into go-gitea:master Aug 11, 2020
@bagasme bagasme deleted the web_src/configuration-placeholder-send-testing-email branch October 8, 2020 04:47
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants