Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cron running API #12421

Merged
merged 7 commits into from
Aug 24, 2020
Merged

Add cron running API #12421

merged 7 commits into from
Aug 24, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Aug 3, 2020

Add API to run cron task

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Add cron running API
45db563 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/feature Completely new functionality. Can only be merged if feature freeze is not active. modifies/api This PR adds API routes or modifies them labels Aug 3, 2020
@zeripath zeripath added this to the 1.13.0 milestone Aug 3, 2020
zeripath
zeripath commented Aug 3, 2020
View reviewed changes
routers/api/v1/admin/cron.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 3, 2020
@lafriks
Copy link
Member

lafriks commented Aug 3, 2020

Swagger lint failed

@zeripath
placate-swagger
08937a8 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 17, 2020
6543
6543 reviewed Aug 17, 2020
View reviewed changes
routers/api/v1/admin/cron.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2020 •
edited
Loading

Codecov Report

Merging #12421 into master will decrease coverage by 0.01%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12421      +/-   ##
==========================================
- Coverage   43.40%   43.39%   -0.02%     
==========================================
  Files         644      645       +1     
  Lines       71249    71281      +32     
==========================================
+ Hits        30929    30933       +4     
- Misses      35302    35331      +29     
+ Partials     5018     5017       -1
Impacted Files Coverage Δ
models/list_options.go 43.47% <0.00%> (-12.08%) ⬇️
routers/api/v1/admin/cron.go 0.00% <0.00%> (ø)
routers/api/v1/api.go 79.01% <100.00%> (+0.12%) ⬆️
modules/log/event.go 57.54% <0.00%> (-1.89%) ⬇️
services/pull/pull.go 41.57% <0.00%> (ø)
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️
modules/indexer/stats/queue.go 64.70% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee04731...436d673. Read the comment docs.

techknowlogick
techknowlogick reviewed Aug 24, 2020
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per @6543 comment

routers/api/v1/admin/cron.go Outdated Show resolved Hide resolved
routers/api/v1/admin/cron.go Outdated Show resolved Hide resolved
routers/api/v1/api.go Outdated Show resolved Hide resolved
@zeripath @techknowlogick
Apply suggestions from code review
e3d4ced 
Co-authored-by: techknowlogick <matti@mdranta.net>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 24, 2020
@techknowlogick techknowlogick merged commit 2ae8c7a into go-gitea:master Aug 24, 2020
@zeripath zeripath deleted the cron-api branch August 24, 2020 16:02
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@zeripath @lafriks @codecov-commenter @techknowlogick @6543 @GiteaBot