Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to update pr headBranch api #12419

Merged
merged 6 commits into from
Aug 4, 2020

Conversation

a1012112796
Copy link
Member

As title.

Signed-off-by: a1012112796 <1012112796@qq.com>
routers/api/v1/api.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 4, 2020
@lunny lunny added the modifies/api This PR adds API routes or modifies them label Aug 4, 2020
@lunny lunny added this to the 1.13.0 milestone Aug 4, 2020
@lunny
Copy link
Member

lunny commented Aug 4, 2020

Otherwise LGTM

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 4, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 4, 2020
routers/api/v1/repo/pull.go Outdated Show resolved Hide resolved
routers/api/v1/repo/pull.go Outdated Show resolved Hide resolved
routers/api/v1/repo/pull.go Outdated Show resolved Hide resolved
}

// default merge commit message
message := fmt.Sprintf("Merge branch '%s' into %s", pr.BaseBranch, pr.HeadBranch)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[OPTIONAL] you could add an optional option in body for the message

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like it to be consistent with UI, so I won't change it for now. Thanks.

@6543
Copy link
Member

6543 commented Aug 4, 2020

not that bad :) - thanks @a1012112796

Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block

@zeripath
Copy link
Contributor

zeripath commented Aug 4, 2020

@6543 are you happy now?

Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am :)

@zeripath
Copy link
Contributor

zeripath commented Aug 4, 2020

make lg-tm work

@zeripath zeripath merged commit 8a6790b into go-gitea:master Aug 4, 2020
@zeripath zeripath changed the title [API] Add update pr headBranch api Add API to update pr headBranch api Aug 4, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants