Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserProfile Page: Render Description #12415

Merged
merged 10 commits into from
Aug 5, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Aug 3, 2020

now you can use Markdown to get something like this:
Bildschirmfoto zu 2020-08-03 13-24-37

@6543 6543 changed the title UserProfile Page: Render Biography UserProfile Page: Render Description Aug 3, 2020
@6543
Copy link
Member Author

6543 commented Aug 3, 2020

It's called Biography in Settings but internaly named Description everywhere

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 3, 2020
Copy link
Member

@a1012112796 a1012112796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feature, I like it. Thanks. 🎉
After this change suggest adding simpleMDE support for description edit box.

@silverwind
Copy link
Member

silverwind commented Aug 3, 2020

If this is supposed to mimic GitHub's recent profile README's, I suggest putting it into a box on the right instead of cramming it into that small box. It should not render at all if the text is empty.

simpleMDE

Please don't for now. We want to get rid of SimpleMDE, not make it harder to migrate off it.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 4, 2020
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Aug 4, 2020
@lunny lunny added this to the 1.13.0 milestone Aug 4, 2020
@6543
Copy link
Member Author

6543 commented Aug 4, 2020

@silverwind now it only render if Description has text in it

@6543
Copy link
Member Author

6543 commented Aug 4, 2020

@lunny @a1012112796 hope you dont mind the change after your LGTM?

@a1012112796
Copy link
Member

Please don't for now. We want to get rid of SimpleMDE, not make it harder to migrate off it.

I see, it's reasonable. I think maybe we can add some note messages on the edit box to let users know the user's description support markdown rules.

@silverwind
Copy link
Member

silverwind commented Aug 4, 2020

I guess this is fine for now, our user profile page will need a rework anyways to allow adding one more tab to it (e.g. create a "Overview" tab and move both profile readme and activity to it, maybe convert Followers/Following into a link to separate pages).

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 4, 2020
@zeripath
Copy link
Contributor

zeripath commented Aug 4, 2020

@6543 I think the tests are genuinely failing here and don't just represent intermittent failures.

@6543
Copy link
Member Author

6543 commented Aug 4, 2020

look's like I'll have to dick into it

@6543
Copy link
Member Author

6543 commented Aug 4, 2020

Interestint throu that the test fail on points where this PR should NOT produce ANY change ...

routers/user/profile.go Outdated Show resolved Hide resolved
routers/user/profile.go Outdated Show resolved Hide resolved
routers/user/profile.go Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Aug 5, 2020

☝️ thats how bug's are produced - in this case the nil exeption didnt let me sleep - catched it

@6543
Copy link
Member Author

6543 commented Aug 5, 2020

@lunny you noticed it at the same time :D

@lunny lunny merged commit 2872a04 into go-gitea:master Aug 5, 2020
@6543 6543 deleted the render-user-Biography branch August 5, 2020 12:34
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants