Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name filter to API for GetMilestoneList #12336

Merged
merged 3 commits into from
Jul 28, 2020
Merged

Add name filter to API for GetMilestoneList #12336

merged 3 commits into from
Jul 28, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 27, 2020 •
edited
Loading

it include also a refactor (merge GetMilestones and GetmilestonesByRepoID)

close #12260

neded for https://gitea.com/gitea/go-sdk/issues/383 and https://gitea.com/gitea/tea/pulls/149

lunny
lunny requested changes Jul 27, 2020
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

models/issue_milestone.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 27, 2020
@6543
Copy link
Member Author

6543 commented Jul 27, 2020

@lunny done

@jolheiser jolheiser added this to the 1.13.0 milestone Jul 27, 2020
@jolheiser jolheiser added modifies/api This PR adds API routes or modifies them type/refactoring Existing code has been cleaned up. There should be no new functionality. type/enhancement An improvement of existing functionality labels Jul 27, 2020
@6543 6543 requested a review from lunny July 27, 2020 15:46
@6543 6543 force-pushed the extend-api_milestone-list-filter-by-name branch from 2dd88ed to b44f188 Compare July 27, 2020 22:18
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 28, 2020
zeripath
zeripath approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I note you've changed the default to do a sort by deadline then by id - we're probably going to have to update our API to allow this kind of multiple sorting at some point.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 28, 2020
@zeripath zeripath changed the title [API] Extend get milestone list by name filter Add name filter to API for GetMilestoneList Jul 28, 2020
@zeripath zeripath merged commit 8bdc979 into go-gitea:master Jul 28, 2020
@6543 6543 deleted the extend-api_milestone-list-filter-by-name branch July 28, 2020 11:45
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

API: extend Get Milestone List to filter by name
5 participants
@6543 @lunny @zeripath @GiteaBot @jolheiser