-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Detect version of sed in Makefile #12319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's possible to install GNU sed on Darwin or FreeBSD so it's better to not assume BSD sed on those platforms but to instead perform version detection for the `GNU` string and only use BSD syntax if absent.
|
🚀 |
techknowlogick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is the way to go. sed --version fails on macOS
|
Yeah, BSD |
|
Switching to |
Co-authored-by: techknowlogick <matti@mdranta.net>
It's possible to install GNU sed on Darwin or FreeBSD so it's better to not assume BSD sed on those platforms but to instead perform version detection for the
GNUstring and only use BSD syntax if absent.