Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable search box autofocus #12229

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Disable search box autofocus #12229

merged 3 commits into from
Jul 27, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jul 12, 2020 •
edited
Loading

Various pages like the issue list autofocus their search box which I find rather intrusive because more often than not I don't want to type into the search box, it's distracting if the focus jumps after page load. Disable this behaviour.

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Jul 12, 2020
@lafriks lafriks added this to the 1.13.0 milestone Jul 12, 2020
@silverwind silverwind changed the title Disable search box autofoxus Disable search box autofocus Jul 13, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 16, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 16, 2020
lunny
lunny requested changes Jul 16, 2020
View reviewed changes
templates/explore/code.tmpl Outdated Show resolved Hide resolved
templates/explore/search.tmpl Outdated Show resolved Hide resolved
templates/repo/issue/search.tmpl Show resolved Hide resolved
@silverwind
Disable search box autofocus on issue/pr pages
3bdf033 
Various pages like the issue list autofocus their search box which I find rather intrusive because more often than not I don't want to type into the search box, it's distracting if the focus jumps after page load. Disable this behaviour.
@silverwind
Copy link
Member Author

@lunny updated to only disable on issue/pr pages.

@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 859094e into go-gitea:master Jul 27, 2020
@silverwind silverwind deleted the no-autofocus branch July 27, 2020 10:23
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaqra jaqra jaqra approved these changes

@6543 6543 6543 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
7 participants
@silverwind @techknowlogick @lunny @6543 @jaqra @lafriks @GiteaBot