Avoid sending "0 new commits" webhooks #12212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Till Faelligen <tfaelligen@gmail.com>
Member
|
wouldn't this result error being logged? |
GiteaBot
added
the
lgtm/need 2
Contributor
Author
|
Yes, at the moment an error would be logged. Should this be a warning/info instead? |
Member
|
Imho it should be handled somewhere in more central place and ignored silently |
Contributor
Author
|
Done. Shouldn't result in anything being logged now. |
lafriks
reviewed
Jul 18, 2020
Co-authored-by: Lauris BH <lauris@nix.lv>
lafriks
approved these changes
Jul 19, 2020
GiteaBot
added
lgtm/need 1
6543
approved these changes
Sep 1, 2020
Member
6543
left a comment
6543
left a comment
There was a problem hiding this comment.
I hope this wont break things again - throug it looks promising
GiteaBot
added
lgtm/done
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids sending messages containing "0 new commits pushed" to services. Other solutions would probably break integration with eg. drone (see #11397)
Closes #10498