Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to showing closed Issues/PR list when there are only closed issues/PRs #12200

Merged
merged 3 commits into from
Jul 9, 2020
Merged

Default to showing closed Issues/PR list when there are only closed issues/PRs #12200

merged 3 commits into from
Jul 9, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 9, 2020

as title - remove one unessesary click sometimes ;)

6543
6543 commented Jul 9, 2020
View reviewed changes
routers/repo/issue.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 9, 2020
@zeripath zeripath changed the title [Enhancement] Issue/Pull list: default is closed when openCount = 0 && closedCount != 0 Default to showing closed Issues/PR list when there are only closed issues/PRs Jul 9, 2020
@zeripath zeripath added the type/enhancement An improvement of existing functionality label Jul 9, 2020
@zeripath zeripath added this to the 1.13.0 milestone Jul 9, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 9, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 9, 2020
@6543
Copy link
Member Author

6543 commented Jul 9, 2020

ready to 🚀

@zeripath zeripath merged commit 16980d1 into go-gitea:master Jul 9, 2020
@6543 6543 deleted the enhancement_closed-default-if-open-is-0 branch July 9, 2020 21:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @lunny @zeripath @GiteaBot