-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable dropzone's timeout #12024
Merged
Merged
Disable dropzone's timeout #12024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
force-pushed
the
dropzonetimeout
branch
from
June 22, 2020 20:26
e64d6a4
to
07479fe
Compare
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload still in progress. This disable that timeout again. Ref: https://www.dropzonejs.com/#config-timeout Ref: go-gitea#10645 Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute Fixes: go-gitea#12022 Fixes: go-gitea#11906
silverwind
force-pushed
the
dropzonetimeout
branch
from
June 22, 2020 20:27
07479fe
to
0fb18ca
Compare
lunny
approved these changes
Jun 23, 2020
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Jun 23, 2020
CirnoT
approved these changes
Jun 23, 2020
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jun 23, 2020
@silverwind please send backport :) |
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Jun 24, 2020
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload still in progress. This disable that timeout again. Ref: https://www.dropzonejs.com/#config-timeout Ref: go-gitea#10645 Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute Fixes: go-gitea#12022 Fixes: go-gitea#11906 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
techknowlogick
added
the
backport/done
All backports for this PR have been created
label
Jun 24, 2020
techknowlogick
pushed a commit
that referenced
this pull request
Jun 24, 2020
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload still in progress. This disable that timeout again. Ref: https://www.dropzonejs.com/#config-timeout Ref: #10645 Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute Fixes: #12022 Fixes: #11906 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload still in progress. This disable that timeout again. Ref: https://www.dropzonejs.com/#config-timeout Ref: go-gitea#10645 Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute Fixes: go-gitea#12022 Fixes: go-gitea#11906 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload still in progress. This disables that timeout again.
Ref: https://www.dropzonejs.com/#config-timeout
Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute
Ref: #10645
Fixes: #12022
Fixes: #11906