Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dropzone's timeout #12024

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jun 22, 2020

Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload still in progress. This disables that timeout again.

Ref: https://www.dropzonejs.com/#config-timeout
Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute
Ref: #10645
Fixes: #12022
Fixes: #11906

Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload
still in progress. This disable that timeout again.

Ref: https://www.dropzonejs.com/#config-timeout
Ref: go-gitea#10645
Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute
Fixes: go-gitea#12022
Fixes: go-gitea#11906
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 23, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 23, 2020
@techknowlogick techknowlogick merged commit ec0743b into go-gitea:master Jun 24, 2020
@techknowlogick
Copy link
Member

@silverwind please send backport :)

silverwind added a commit to silverwind/gitea that referenced this pull request Jun 24, 2020
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload
still in progress. This disable that timeout again.

Ref: https://www.dropzonejs.com/#config-timeout
Ref: go-gitea#10645
Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute
Fixes: go-gitea#12022
Fixes: go-gitea#11906

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Jun 24, 2020
techknowlogick pushed a commit that referenced this pull request Jun 24, 2020
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload
still in progress. This disable that timeout again.

Ref: https://www.dropzonejs.com/#config-timeout
Ref: #10645
Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute
Fixes: #12022
Fixes: #11906

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload
still in progress. This disable that timeout again.

Ref: https://www.dropzonejs.com/#config-timeout
Ref: go-gitea#10645
Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute
Fixes: go-gitea#12022
Fixes: go-gitea#11906

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
5 participants