Skip to content

Rework blame template and styling #11885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 15, 2020
Merged

Rework blame template and styling #11885

merged 3 commits into from
Jun 15, 2020

Conversation

@CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Jun 14, 2020 •
edited
Loading

  • Fix vertical align between line numbers
    firefox_2020-06-14_18-19-02
  • Update template to use same styling as file view; fixes align of buttons
    firefox_2020-06-14_19-01-32
  • Increase width to 98% to show more content when browsing blame, similar to GitHub
  • Remove edit/delete file buttons during blame view, similar to GitHub
  • Make border line continuous

chrome_2020-06-14_18-58-55

chrome_2020-06-14_18-59-01

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Jun 14, 2020
@lafriks lafriks added this to the 1.13.0 milestone Jun 14, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 14, 2020
@lafriks
Copy link
Member

lafriks commented Jun 14, 2020

Great work, looks nice

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 15, 2020
@techknowlogick
Copy link
Member

techknowlogick commented Jun 15, 2020

ping LG-TM

@techknowlogick techknowlogick merged commit c878098 into go-gitea:master Jun 15, 2020
@CirnoT CirnoT deleted the blame-tmpl branch June 15, 2020 18:53
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT @techknowlogick
Rework blame template and styling (go-gitea#11885)
817656e 
* Rework blame template and styling

* cleanup template and add missing NumLines

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@richmahn richmahn mentioned this pull request Sep 14, 2020
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

5 participants

@CirnoT @lafriks @techknowlogick @mrsdizzie @GiteaBot