Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide diff and patch API endpoints #11751

Merged

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jun 3, 2020

The diff and patch endpoints on the main routes are not accessible by token
therefore we provide new API based endpoints for these

Fix #10923

Signed-off-by: Andrew Thornton art27@cantab.net

The diff and patch endpoints on the main routes are not accessible by token
therefore we provide new API based endpoints for these

Fix go-gitea#10923

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the modifies/api This PR adds API routes or modifies them label Jun 3, 2020
@zeripath zeripath added this to the 1.13.0 milestone Jun 3, 2020
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
@6543
Copy link
Member

6543 commented Jun 4, 2020

Looks good just need to check if it colide with gh api

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 4, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 4, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 4, 2020
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Jun 4, 2020
@lafriks
Copy link
Member

lafriks commented Jun 5, 2020

make lgtm work

@lafriks lafriks merged commit f761a37 into go-gitea:master Jun 5, 2020
@zeripath zeripath deleted the fix-10923-provide-diff-patch-API-endpoints branch June 5, 2020 11:40
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
* Provide diff and patch API endpoints

The diff and patch endpoints on the main routes are not accessible by token
therefore we provide new API based endpoints for these

Fix go-gitea#10923

Signed-off-by: Andrew Thornton <art27@cantab.net>

* placate swagger

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Make the response an actual string

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] diff_url & patch_url not accesible via token on private repos
5 participants